Implement Faction logs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 7, 2020 21:50
This change is to account for events being cancelled, so logging can't be done in the call() method
These may be incorrectly done, someone pls take a look ty
DaPigGuy
requested changes
May 15, 2020
DaPigGuy
approved these changes
May 15, 2020
Aericio
requested changes
May 15, 2020
src/DaPigGuy/PiggyFactions/commands/subcommands/management/LogsSubCommand.php
Outdated
Show resolved
Hide resolved
src/DaPigGuy/PiggyFactions/commands/subcommands/management/LogsSubCommand.php
Show resolved
Hide resolved
src/DaPigGuy/PiggyFactions/commands/subcommands/management/LogsSubCommand.php
Show resolved
Hide resolved
src/DaPigGuy/PiggyFactions/commands/subcommands/management/LogsSubCommand.php
Outdated
Show resolved
Hide resolved
Aericio
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure your pull request complies with these guidelines:
What does the PR change?
This PR implements a basic logging system for factions to see the details of various faction related events, f.e: When a player is kicked from the faction, and when they occurred.
This feature would be nice for faction leaders to monitor the activity of fellow staff members, and for faction members to know what their higher-ups are upto.
Testing Environment
Extra Information
MySQL queries might have some issues, I haven't tested using a MySQL db, just SQLite