Merge pull request #39 from shaggyrec/fix-temp-clean-up-for-concurren…

…tly-reading Fix temp clean up for concurrently reading
DaSpawn · Apr 4, 2019 · efa78b1 · efa78b1
2 parents 4520190 + 5b342c0
commit efa78b1
Show file tree

Hide file tree

Showing 5 changed files with 381 additions and 345 deletions.
diff --git a/lib/workbook.js b/lib/workbook.js
@@ -8,7 +8,7 @@
 
 const Path = require('path')
 const Fs = require('fs')
-const Temp = require('temp')
+const Tmp = require('tmp')
 const Stream = require('stream')
 const unzipper = require('unzipper')
 const Sax = require('sax')
@@ -94,8 +94,6 @@ function XlsxStreamReaderWorkBook (options) {
     }
   })
 
-  Temp.track()
-
   self._handleWorkBookStream()
 }
 Util.inherits(XlsxStreamReaderWorkBook, Stream)
@@ -160,9 +158,10 @@ XlsxStreamReaderWorkBook.prototype._handleWorkBookStream = function () {
                 self.parsedSharedStrings === false ||
                 self.waitingWorkSheets.length > 0
               ) {
-                var stream = Temp.createWriteStream()
+                const { name } = Tmp.fileSync({})
+                const stream = Fs.createWriteStream(name)
 
-                self.waitingWorkSheets.push({sheetNo: sheetNo, name: entry.path, path: stream.path, sheetPath: sheetPath})
+                self.waitingWorkSheets.push({sheetNo: sheetNo, name: entry.path, path: name, sheetPath: sheetPath})
 
                 entry.pipe(stream)
               } else {
@@ -191,7 +190,6 @@ XlsxStreamReaderWorkBook.prototype._handleWorkBookStream = function () {
             workSheet.on('end', function (node) {
               ++currentBook
               if (currentBook === self.waitingWorkSheets.length) {
-                Temp.cleanupSync()
                 setImmediate(self.emit.bind(self), 'end')
               } else {
                 setImmediate(processBooks)