Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surfaces that will never be used for drawing still get added in RB_RenderDrawSurfaces() #1096

Closed
VReaperV opened this issue Apr 23, 2024 · 0 comments · Fixed by #1097
Closed

Comments

@VReaperV
Copy link
Contributor

See https://users.unvanquished.net/~sweet/reaper/map-example_1.dpk for an example.

The sky and portal surfaces are skipped in R_CreateWorldVBO(), but RB_RenderDrawSurfaces() still adds the sky surfaces, which it ends up uselessly copying into tess.verts and tess.indexes and, in this case, overflowing SHADER_MAX_VERTEXES. Those surfaces are never used for drawing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant