Add post-cast delay to all wands, scrolls and potions AND rods. Start all SpellItems off identified, and remove karma check from Remove Curse potions. Rod delay time adjustable live. #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Players are reporting that these items are being spammed in PvP with ill effects (perma-hold, perma-truce among others). Using a spell item will now have the same delay as the spell would normally. While the items can still be spammed, and might need further mitigation, this serves as a good first step. Note that rods can still be spammed, no changes there yet.
Although this appears to affect the "go bad timer", this is disabled elsewhere so this behavior doesn't change.
skittles1
changed the title
Can set this easily live (including setting it low enough to be effectively zero). Whether we use this or not, we need the setting.
skittles1
changed the title
|
I like the change for wands, scrolls and potions, I don't like it for rods :-) |
skittles1
force-pushed
the
delayspellitem
branch
from
e53ab97
to
ef74223
Compare
Properties are for setting individual items, classvars are for every item. Add a message to user if they try to use a disabled item.
skittles1
force-pushed
the
delayspellitem
branch
from
ef74223
to
f44b70f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Players are reporting that these items are being spammed in PvP with ill effects (perma-hold, perma-truce among others). Using a spell item will now have the same delay as the spell would normally. While the items can still be spammed, and might need further mitigation, this serves as a good first step.
Rods have also been given a delay of default 1000ms, which can be adjusted live.
Also start all SpellItems off identified - a common complaint from players was that they couldn't reliably use these items while building because they often weren't sure what the item would do (and some have identical colors). Although this makes Reveal and Identify less useful, I think it is necessary.
Removed the karma requirement from Remove Curse potions - until we have a large population, this is needed to prevent players requiring a Shal 2 mule for getting rid of cursed items.