Add sanity checks for code that uses SquaredDistanceTo in NoMoveOn. #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skittles1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sanity check for different rooms which returns $ was added to SquaredDistanceTo() in nomoveon.kod in the last update, unfortunately there were functions using this that either don't have both objects in the same room (yelling) or have cases where one object has $ room (casting an attack spell on a monster as it dies). This pull request fixes both those cases by not calling Sqdt() in both of those cases. There are other cases where this error may occur but these are the two most frequent, and I believe the check Gar put in place will likely catch more important errors (that we won't see in the log) than if it isn't there.
NOTE: the atakspel.kod change needs 104 testing, I couldn't trigger it locally due to needing poor latency to test earthquake/blast of fire combos which will trigger the error.