Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/support select fields #440

Merged
merged 5 commits into from
Mar 6, 2024
Merged

feature/support select fields #440

merged 5 commits into from
Mar 6, 2024

Conversation

simonlsk
Copy link
Contributor

Spec

  • Add selectFields field in the datasourceQuery.
  • First introspect if field is available and require it only if possible.

@dagshub DagsHub
Copy link

dagshub bot commented Feb 26, 2024

Join the discussion on DagsHub!

kbolashev
kbolashev approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this isn't really being exposed to the user from what I read, right?

dagshub/data_engine/client/gql_introspections.py Show resolved Hide resolved
@simonlsk simonlsk merged commit 4011bcf into master Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbolashev kbolashev kbolashev approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonlsk @kbolashev