Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix data engine not being able to download files with reserved URL symbols in the file paths #465

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

kbolashev
Copy link
Member

Reproduction:

  • Create a file structure that includes a # symbol somewhere in the path. For example a file at the path aaa # bbb/file.txt
  • Create a datasource from that structure
  • Run:
# get datasource before that
ds.all().download_files()

The file with the hash symbol will fail to download.

I added a test that checks that the hash doesn't show up

@kbolashev kbolashev added the bug Something isn't working label Apr 15, 2024
@kbolashev kbolashev requested a review from simonlsk April 15, 2024 14:31
@kbolashev kbolashev self-assigned this Apr 15, 2024
Copy link

dagshub bot commented Apr 15, 2024

Copy link
Contributor

@simonlsk simonlsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (As in looks great to me)

@kbolashev kbolashev merged commit a25655d into master Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants