Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Paths for fds add #78

Merged
merged 10 commits into from Jul 19, 2021
Merged

Conversation

mohithg
Copy link
Contributor

@mohithg mohithg commented Jul 18, 2021

  • fds add right now only supports one path (or .) but we need to make fds add support multiple paths
    eg: fds add path1/file1 path2

@mohithg mohithg linked an issue Jul 18, 2021 that may be closed by this pull request
@mohithg mohithg requested a review from guysmoilov July 18, 2021 08:11
@mohithg mohithg changed the base branch from main to multiple-paths July 19, 2021 11:33
@guysmoilov guysmoilov merged commit 9d63977 into multiple-paths Jul 19, 2021
@guysmoilov guysmoilov deleted the mohithg/multiple-paths branch July 19, 2021 11:45
guysmoilov pushed a commit that referenced this pull request Jul 19, 2021
* Changing add parser to support multiple paths and chaning following function typing to support List[str] instead of str (#71)

Co-authored-by: Mohith G <mohithgm@gmail.com>

* Support Multiple Paths for fds add (#78)

* Support multiple paths in dvc

* support multiple paths in git

* Add tests

* Add fds test

* Add test for fds

* Add test for dvc

* Add test for git

* Bug fix for all

* Add a fix for more performance

* Fix lint

* Fix a bug in git ignore

Co-authored-by: Tom Ron <rontom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple paths in fds add
2 participants