Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parameters to be send #49

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

shabanovd
Copy link
Contributor

@shabanovd shabanovd commented Feb 10, 2023

Base on documentation create, get, update, patch and remove service methods have params argument.

async get(id: Id, params: Params) {}
async create(data: any, params: Params) {}
async update(id: NullableId, data: any, params: Params) {}
async patch(id: NullableId, data: any, params: Params) {}
async remove(id: NullableId, params: Params) {}

This PR is adding params argument to all that methods.

@Dahkenangnon
Copy link
Owner

Hi @shabanovd

Any description about your PR please ?

What the new feature feature do you enable ?

Then I can review and merge.

Thank, for starting to contribute to this.... waiting for your reply

@shabanovd
Copy link
Contributor Author

Hey @Dahkenangnon, I updated the description. Let me know if you still have questions.

@Dahkenangnon
Copy link
Owner

Dahkenangnon commented Feb 28, 2023

Base on documentation create, get, update, patch and remove service methods have params argument.

async get(id: Id, params: Params) {}
async create(data: any, params: Params) {}
async update(id: NullableId, data: any, params: Params) {}
async patch(id: NullableId, data: any, params: Params) {}
async remove(id: NullableId, params: Params) {}

This PR is adding params argument to all that methods.

These params argument are new feature enabled by recent version of the featherjs framework. Even I merged be sure to have the right version on your backend.

@Dahkenangnon Dahkenangnon added the enhancement New feature or request label Feb 28, 2023
@shabanovd
Copy link
Contributor Author

It's quite old staff, see https://buzzard.docs.feathersjs.com/api/services.html

@Dahkenangnon Dahkenangnon merged commit 3313590 into Dahkenangnon:master Feb 28, 2023
@Dahkenangnon
Copy link
Owner

@Dahkenangnon
Copy link
Owner

It's quite old staff, see https://buzzard.docs.feathersjs.com/api/services.html

Are you interested to become core contributor for this packages ?

@Dahkenangnon
Copy link
Owner

It's quite old staff, see https://buzzard.docs.feathersjs.com/api/services.html

Are you interested to become core contributor for this packages ?

@shabanovd , I need some help to keep maintaining it. We can continue discussion via email if you want

@shabanovd
Copy link
Contributor Author

@Dahkenangnon sure, I can help you with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants