Warning/Analysis Fixes.

Fixes up the deprecated __private_extern__ usage, only frees passwordBytes if non-NULL, and updated to Xcode 4.6 project setting recommendations.
Daij-Djan · Mar 28, 2013 · 02c330f · 02c330f
1 parent db34fc8
commit 02c330f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/PTHotkey/PTKeyBroadcaster.h b/PTHotkey/PTKeyBroadcaster.h
@@ -17,4 +17,4 @@
 
 @end
 
-__private_extern__ NSString* PTKeyBroadcasterKeyEvent; //keys: keyCombo as PTKeyCombo
+__attribute__((visibility("hidden"))) NSString* PTKeyBroadcasterKeyEvent; //keys: keyCombo as PTKeyCombo
diff --git a/QuickRadar.xcodeproj/project.pbxproj b/QuickRadar.xcodeproj/project.pbxproj
@@ -553,7 +553,7 @@
 		E1CC5180156257BF0027FB83 /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0450;
+				LastUpgradeCheck = 0460;
 			};
 			buildConfigurationList = E1CC5183156257BF0027FB83 /* Build configuration list for PBXProject "QuickRadar" */;
 			compatibilityVersion = "Xcode 3.2";
@@ -682,7 +682,10 @@
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				ARCHS = "$(ARCHS_STANDARD_64_BIT)";
 				CLANG_ENABLE_OBJC_ARC = YES;
-				COMBINE_HIDPI_IMAGES = YES;
+				CLANG_WARN_CONSTANT_CONVERSION = YES;
+				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
 				GCC_C_LANGUAGE_STANDARD = gnu99;
 				GCC_DYNAMIC_NO_PIC = NO;
@@ -710,7 +713,10 @@
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				ARCHS = "$(ARCHS_STANDARD_64_BIT)";
 				CLANG_ENABLE_OBJC_ARC = YES;
-				COMBINE_HIDPI_IMAGES = YES;
+				CLANG_WARN_CONSTANT_CONVERSION = YES;
+				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				GCC_C_LANGUAGE_STANDARD = gnu99;

diff --git a/QuickRadar/QRRadarSubmissionService.m b/QuickRadar/QRRadarSubmissionService.m
@@ -467,7 +467,9 @@ - (NSString *)radarPassword
 															  (void **)&passwordBytes,
 															  NULL);
 	NSString *password = [[NSString alloc] initWithBytes:passwordBytes length:passwordLength encoding:NSUTF8StringEncoding];
-	SecKeychainItemFreeContent(NULL, passwordBytes);
+    if (passwordBytes != NULL) {
+        SecKeychainItemFreeContent(NULL, passwordBytes);
+    }
 
 	return password;