Add tests and refactor MTurkLargeRecruiter #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesnyder
changed the title
jessesnyder
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1496 +/- ##
========================================
+ Coverage 85.7% 85.7% +0.1%
========================================
Files 30 30
Lines 4010 4015 +5
Branches 538 536 -2
========================================
+ Hits 3434 3439 +5
- Misses 457 458 +1
+ Partials 119 118 -1 |
vlall
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought I'd found a subtle bug in the MTurkLargeRecruiter, because the logic of the recruit() method was hard to follow. This PR just adds or clarifies some tests, and then refactors that method.
Motivation and Context
How Has This Been Tested?
Full automated test coverage.