fix chatroom demo and standardize config #1600
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
======================================
Coverage 85.8% 85.8%
======================================
Files 30 30
Lines 4054 4054
Branches 540 540
======================================
Hits 3478 3478
Misses 457 457
Partials 119 119 |
demos/dlgr/demos/chatroom/config.txt
Outdated
| @@ -21,12 +21,12 @@ browser_exclude_rule = MSIE, mobile, tablet | |||
|
|
|||
| [Database] | |||
| database_url = postgresql://postgres@localhost/dallinger | |||
| database_size = hobby-dev | |||
| database_size = standard-0 | |||
There was a problem hiding this comment.
Was it necessary to use standard-0? did it not work on hobby-dev?
The hobby tier does not cost anything as far as I recall, so if someone does want to or have the means to pay, they can still use the demo knowing they wont be charged (even though they have to provide a credit card, in order to use redis in all dallinger demos)
There was a problem hiding this comment.
I think we're all over the place with some demos have hobby-dev vs standard-0. Hobby is cheaper.
"Hobby Tier — For apps that can tolerate up to 4 hours of downtime per month
Standard Tier — For apps that can tolerate up to 1 hour of downtime per month"
There was a problem hiding this comment.
I think hobby-dev is free, standard-0 you have to pay for.
I do not see any indication of payment requirements for hobby-dev, standard costs $50/month
https://devcenter.heroku.com/articles/heroku-postgres-plans#standard-tier
|
|
||
| [Server] | ||
| dyno_type = free | ||
| dyno_type = hobby |
There was a problem hiding this comment.
That seems more standardized
vlall
force-pushed
the
stories/457-chatroom-demo
branch
from
d203e0c
to
36dee32
Compare
Description
Use same config as other demos, and change dependency order to avoid conflict.
Motivation and Context
To make the demo work.