(WIP) Story 145: Serve ad from heroku, not psiturk #425
Conversation
Instead of using subprocess to call curl, then subprocess to grep the server logs, make /launch return the relevant info for recruitment directly and call it with requests.
| # them to start the task again. | ||
| raise ExperimentError('already_started_exp_mturk') | ||
| elif status == COMPLETED: | ||
| if status == 'working' and part.end_time is not None: |
There was a problem hiding this comment.
I think this should be if status == 'submitted': and we should make sure that the /worker_complete route updates the status to 'submitted'
Good catch on the difference in how the Dallinger participant model handles the status field.
There was a problem hiding this comment.
That's not the case. I tried this at first, before I completely understood how the notifications were working. 'submitted' means that externalSubmit has been called and the HIT is complete. A failure callback could still be received from mturk after worker_complete.
worker_complete is called in the popup window, the job of which is essentially to mark the user's session as being over. It then refreshes its window.opener and closes itself. The window.opener is the iframe inside mechanical turk, which then needs to show the externalSubmit button, which actually ends the task. As soon as externalSubmit is called, the parent of that iframe, the HIT info page on MTurk changes to being a confirmed page and a callback is made to set the status to be 'submitted'. If the iframe is reloaded before the completed state it shows an error.
One other way of doing this would be to change the state enum to have a state between 'working' and 'submitted', like 'readytosubmit' and have worker_complete update the status there.
There was a problem hiding this comment.
Okay, right, thanks for clarifying.
| {% if mode == 'debug' %} | ||
| <p>If this were a real HIT, you would push a button to finish at this stage. | ||
| {% else %} | ||
| <p>To complete the HIT, simply press the button below.</p> |
There was a problem hiding this comment.
For sandbox/production modes, is there a reason we can't or don't want to submit the form automatically?
For debug mode, I think we still want to have a form, which submits to an endpoint that calls dallinger.experiment_server.experiment_server._debug_notify the way that the /ad_address endpoint used to. That way we can also debug things that happen in response to notifications when working locally.
There was a problem hiding this comment.
I didn't consider changing the existing user-facing behaviour to be a part of this story, but there is an argument for it. However, when the submit button is hit the mturk window changes, so it's possible someone would get lost as to where their session was.
As to the _debug_notify, that's something I missed. I wasn't aware that ad_address was calling it. However, as ad_address is called in dallinger.js, I think it should be called automatically there rather than from a manual button press?
| if self.config.get('launch_in_sandbox_mode'): | ||
| lookup_url = "https://workersandbox.mturk.com/mturk/preview?groupId={type_id}" | ||
| else: | ||
| lookup_url = "https://worker.mturk.com/mturk/preview?groupId={type_id}" |
There was a problem hiding this comment.
This is failing in tests because type_id is not there.
There was a problem hiding this comment.
I did not test this on the production environment, only in the sandbox. What do we have available?
There was a problem hiding this comment.
I meant that running tox fails.
There was a problem hiding this comment.
So it does. Looks like we need to return info from the mock's create_hit.
| @@ -1 +1 @@ | |||
| dallinger == 2.7.0 | |||
| -e git://github.com/Dallinger/Dallinger.git@development#egg=dallinger | |||
There was a problem hiding this comment.
Please don't include this change.
There was a problem hiding this comment.
Yeah, accidental adding. I never intended for that to be committed.
Current coverage is 51.90% (diff: 18.91%)
@@ stories/137-mturkrecruiter-dev-rebase #425 diff @@
=======================================================================
Files 25 25
Lines 2649 2676 +27
Methods 0 0
Messages 0 0
Branches 418 425 +7
=======================================================================
+ Hits 1359 1389 +30
+ Misses 1155 1147 -8
- Partials 135 140 +5
|
(still in progress; opening PR for ease of review)
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):