Add support for magit-status

[DamienCassou]

No description provided.

[DamienCassou]

/cc @Fuco1

[Fuco1]

I was just about to write this myself actually :D Made a note for today's evening.

[Fuco1]

I would also add some end logic, for example when you have the "Unpulled from" or "Unmerged into" headings I would like to get to the last commit (for example I want to do an interactive rebase). Right now it goes two lines below that, which is pretty useless probably.

Unmerged into upstream-branch (2)
85d8881 Bar
499b347 Foo

<point ends up here>

Should land at the last hash. What do you think?

[DamienCassou]

done. Does it work for you now?

[Fuco1]

@DamienCassou Also if you want a review you can use the "Reviewers" in the right-hand column and select me there. That pings me the same way as adding an @ mention and it doesn't require additional comment.

[Fuco1]

You can also see all your requested reviews in the dashboard so that is also helpful for organization: https://github.com/pulls/review-requested

[DamienCassou]

Thanks for the feedback and comments.

use the "Reviewers" in the right-hand column and select me

I will do that

You can also see all your requested reviews in the dashboard

I didn't know that, thanks!

[Fuco1]

This gets really crazy for me because magit uses invisible blocks a lot. These simple searches don't handle it very well.

I think using

(magit-section-backward)
(magit-section-backward)

would work best. Look at the definition of that, it is insanely complicated! (I think we need to call it twice to get to the beginning of the previous relevant line)

[DamienCassou]

Can you tell me how to get a status buffer where (beginend--goto-nonwhitespace) doesn't work?

[Fuco1]

If you have the section Unstaged changes as the last one (or Staged changes) and the last change set is collapsed, the cursor will jump to different positions on repeated invocations.

[DamienCassou]

thank you very much. I implemented your suggestion. I guess that for magit-status, imenu support makes more sense than beginend. But it's still cool to have it working. Thanks.