Smartly reactivate beginend when narrowing is in effect #33
Conversation
DamienCassou
force-pushed
the
widen-before-moving
branch
from
2a7b34c
to
427d20c
Compare
DamienCassou
force-pushed
the
widen-before-moving
branch
from
427d20c
to
576dc2a
Compare
|
Up |
| (defun beginend--out-of-bounds-p (point) | ||
| "Return non-nil if POINT is outside [`point-min', `point-max']. | ||
| This is possible if buffer was narrowed after POINT was stored." | ||
| (not (<= (point-min) point (point-max)))) |
There was a problem hiding this comment.
This only works in 25+. Is that our lowest-supported version?
There was a problem hiding this comment.
Apparently this got added in Emacs 24.4:
Numeric comparison functions =, <, >, <=, >= can now take many arguments.
That's good enough for me.
There was a problem hiding this comment.
I also added tests and Travis builds this package on Emacs 24.5.
There was a problem hiding this comment.
Oh, okey. Somehow I was under the impression it's a 25+ feature. Let's go ahead with this then. But we should probably add a version constraint to the requirements.
There was a problem hiding this comment.
But we should probably add a version constraint to the requirements.
beginend.el already contains:
;; Package-Requires: ((emacs "24.4"))
Do you have something else in mind?
DamienCassou
force-pushed
the
widen-before-moving
branch
2 times, most recently
from
6131afb
to
30ac9ee
Compare
Instead of just deactivating beginend when a buffer is narrowed, this patch widens the buffer, applies the beginend procedure, and checks if point has moved outside the original narrowed region.
DamienCassou
force-pushed
the
widen-before-moving
branch
from
30ac9ee
to
5a7e470
Compare
Instead of just deactivating beginend when a buffer is narrowed, this
patch widens the buffer, applies the beginend procedure, and checks if
point has moved outside the original narrowed region.