Add a console user provider #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderVerkuil
force-pushed
the
improvement/console-user
branch
4 times, most recently
from
cf19da4
to
2ae5236
Compare
Also write some tests regarding the console user provider, to verify that it actually is working. Fixes DamienHarper#267
SanderVerkuil
force-pushed
the
improvement/console-user
branch
from
2ae5236
to
96bc3c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 93.18% 93.35% +0.16%
==========================================
Files 14 16 +2
Lines 279 301 +22
==========================================
+ Hits 260 281 +21
- Misses 19 20 +1
Continue to review full report at Codecov.
|
DamienHarper
approved these changes
Mar 31, 2022
|
@SanderVerkuil Thanks for the contribution, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267