-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"global" run time enable (2) #61
"global" run time enable (2) #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webmasterMeyers A few points:
- Please, replace the
AuditConfiguration::setEnabled(bool $enabled)
with two separate methodsAuditConfiguration::enable()
andAuditConfiguration::disable()
orAuditConfiguration::enableAudit()
andAuditConfiguration::disableAudit()
as you like. - Make these methods fluent (return current instance to allow method chaining)
- Checkout this dedicated README for more information about tests -- you may start by editing
tests/DoctrineAuditBundle/AuditConfigurationTest.php
and add a new test methodsAuditConfigurationTest.php ::testIsAuditedWhenAuditIsDisabled()
(to testisAudited
method when globalenabled
flag isfalse
) andAuditConfigurationTest.php ::testIsAuditedWhenAuditIsEnabled()
(to testisAudited
method when globalenabled
flag istrue
).
|
Please, do run code coverage once your tests are done. Then, open |
Thanks for walking me through all that! |
My pleasure |
Continuation from #59, Code is updated as you requested. I have not yet added any unit-tests. Not sure how, yet. But this works as manually tested.
This is also much simpler!