Nested LoggerChains causing big call stack #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding AuditLogger. Also added null check to AuditHelper
DamienHarper
reviewed
Sep 4, 2019
DamienHarper
approved these changes
Sep 4, 2019
DamienHarper
requested changes
Sep 4, 2019
|
Made the changes requested. Let me know if everything looks alright! Thanks! |
DamienHarper
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue 70. LoggerChains are nested inside each other and when Doctrine calls startQuery on the EntityManager's SQLLogger, the LoggerChains will create call stacks for each nest. If xdebug is enabled, once the call stack reaches the "max_nesting_level", an Exception will be thrown.
This code flattens the EntityManager's SQLLogger by detecting if it is already a LoggerChain and if so only appending the AuditLogger created.