-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support to php 8 attributes #40
Conversation
275bc44
to
c70be96
Compare
@djpremier Thanks a lot for this PR, much appreciated! You may try something like |
Thanks, done. I remove the change because on 3.0 the config file is renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests using Symfony 3.4 and PHP 8 fail but as far as I know, PHP 8 is not supported with Symfony 3.4
Tests should not even be run with such a config.
I will check. |
thanks @djpremier |
I'm working on this change also for |
Add support to php 8 attributes, keeping compatibility with annotations.