Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip embedded class from schema listener #189

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Skip embedded class from schema listener #189

merged 2 commits into from
Dec 19, 2023

Conversation

DamienHarper
Copy link
Owner

This is an updated version of PR #183 from @guillaume-sainthillier

When multiple storage is used, we can't handle embedded classes for a storage manager

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07235c1) 94.40% compared to head (4a436a0) 94.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #189   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          44       44           
  Lines        1823     1823           
=======================================
  Hits         1721     1721           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit bdfbaef into 2.x Dec 19, 2023
47 checks passed
@DamienHarper DamienHarper deleted the fix-embed branch December 19, 2023 20:35
DamienHarper added a commit that referenced this pull request Dec 19, 2023
Co-authored-by: Guillaume Sainthillier <guillaume.sainthillier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants