Switch from arrays to DTO classes when passing event information around #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janklan
commented
Mar 26, 2022
janklan
commented
Mar 26, 2022
src/Provider/Doctrine/Auditing/Transaction/TransactionHydrator.php
Outdated
Show resolved
Hide resolved
janklan
commented
Mar 26, 2022
DamienHarper
requested changes
Mar 28, 2022
src/Provider/Doctrine/Auditing/Transaction/TransactionHydrator.php
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 95.75% 94.47% -1.29%
==========================================
Files 35 40 +5
Lines 1390 1429 +39
==========================================
+ Hits 1331 1350 +19
- Misses 59 79 +20
Continue to review full report at Codecov.
|
|
I'm not sure why would the CI fail with exit code 8... :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #91 (comment), here is the PR that uses DTO classes instead of arrays in order to improve code robustness.
I added a dedicated method to each event type. It expands the
TransactionAPI surface a bit, but it also enables static code analysers to do their thing. Comparing to passing an array with vague structure that's later magically converted to something useful, I think the surface expansion is an acceptable cost to pay.