Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile.cson is incorrectly recognized as Makefile #311

Closed
50Wliu opened this issue Apr 3, 2016 · 4 comments
Closed

makefile.cson is incorrectly recognized as Makefile #311

50Wliu opened this issue Apr 3, 2016 · 4 comments
Assignees
@Alhadis
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon.

Comments

@50Wliu
Copy link

50Wliu commented Apr 3, 2016

While Makefiles can have any file extension, it's somewhat jarring to have all other CSON files have the CSON icon but makefile.cson to have the Makefile one 馃槢.
@Alhadis
Copy link
Member

Alhadis commented Apr 3, 2016

Is this a common occurrence?

I made Makefile a wildcard pattern because of the colossal plethora of various file extensions... I could make an exception for this particular extension, but I'd prefer to know if there are others I should consider too.

@Alhadis Alhadis self-assigned this Apr 3, 2016
@50Wliu
Copy link
Author

50Wliu commented Apr 3, 2016

Is this a common occurrence?

Nope, pretty sure not. I'm just working on language-make right now.

@Alhadis
Copy link
Member

Alhadis commented Apr 3, 2016

Gotcha.

Actually, I'll remove the wildcard matching for lowercase makefile, since it's really Makefile that it was added to fix.

@Alhadis Alhadis closed this as completed in 511bd4e Apr 3, 2016
@Alhadis
Copy link
Member

Alhadis commented Apr 3, 2016

Fixed, mate. =) This'll be included in the next patch release.

@Alhadis Alhadis added bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon. labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alhadis Alhadis

Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. filetype-support New file-extensions or filename patterns associated with an existing icon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alhadis @50Wliu