fix: Simplify view definition options. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the shortcomings of the original interface which required special avoidance of sqlalchemy and alembic's normal function for awareness of tables. Now instead, the registration is done in a way that ensures alembic/sqlalchemy ignore the objects automatically, while still making them usable on the orm query interface.
In hosted Postgres, like AWS, pg_authid is protected/unavailable. In reality, we only need the role mapping to oid, which is available on the pg_roles table instead.
DanCardin
force-pushed
the
dc/view-diff
branch
from
26b9d41
to
ab7a803
Compare
DanCardin
force-pushed
the
dc/view-diff
branch
from
ab7a803
to
6f43871
Compare
Pull Request Test Coverage Report for Build 3713960042
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the shortcomings of the original interface which required special
avoidance of sqlalchemy and alembic's normal function for awareness of
tables.
Now instead, the registration is done in a way that ensures
alembic/sqlalchemy ignore the objects automatically, while still making
them usable on the orm query interface.