Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel maxSize #20

Closed
PGMaster opened this issue Jan 25, 2018 · 4 comments
Closed

Panel maxSize #20

PGMaster opened this issue Jan 25, 2018 · 4 comments

Comments

@PGMaster
Copy link

I am working on an app which requires 3 panes. But the two panes at the end should not expand after a particular limit. It would be good to have maxSize to be set for each pane.

@DanFessler
Copy link
Owner

I agree that should be added. in the meanwhile though you could potentially set a minSize on the left-most panel which would effectively limit how far the other two panels could be expanded.

@pdfowler
Copy link

@DanFessler I've just submitted a PR with maxWidth functionality. I was really happy to see a multi-panel project that didn't require me to nest in groups of Two. However, maxWidth is a core requirement for us, and I figured it would help the project.

I also broke apart your modules - helps when looking at new code to know where each property/callback/function lives. 😇

LMK what you think. Cheers!

@DanFessler
Copy link
Owner

@pdfowler left some comments/questions for you on the PR

@DanFessler
Copy link
Owner

resolved in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants