-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional "Handle" for Panels #22
Comments
I like this proposal. I have some followup comments/questions
|
May be name could be 'dividerHandle' as the handle applies to dividers. Also, since this would be great for Mobile, ability to recognize gestures is important (but please do not use Hammer.js for those, as Hammer.JS does not support server-side deployment, which is a problem, at least for me :-) ) |
I want to remove the cursor in the content tag |
I've seen a handful of implementations of panels like this where there's a small "handle" on the resizer divider. This can be really useful for mobile (eg: #16 )since it is often more useful to "toggle" panels on mobile rather than drag to resize.
This is something I'm looking at doing, but wanted to file an issue first to see if anyone in the community had implemented something like this.
Proposed Behavior:
panelWidths
configs objectonHandleClick
called with argumentspanels
(like currentonUpdate
method), along with thepanelIndex
of the selected panel divider.onHandleClick
would only fireonMouseUp
ifisDragging === false
Questions:
What does
panelIndex
refer to?If a handle is placed on panel 0, it is placed on the divider between panels 0 and 1. This is straightforward.
In a three column layout with a
stretch
column between two sidebars, does the handle for the righthand sidebar go on panel 1 or panel 2?possible solution:
handle
could take either a single DOM element (as described above, ie: "basic config mode"), or it could take an object with properties:handle.component
,handle.direction
, etcThe text was updated successfully, but these errors were encountered: