Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fork doesn't save the "updateInstall" section. #23

Closed
SwiftMove opened this issue Jan 21, 2022 · 8 comments
Closed

This fork doesn't save the "updateInstall" section. #23

SwiftMove opened this issue Jan 21, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@SwiftMove
Copy link

SwiftMove commented Jan 21, 2022

For some reason this fork of tsschecker isn't saving the "updateInstall" data like the 1Conan fork does. I'm using the latest Windows 64-bit releases from each repo.

tsschecker.exe -d iPhone10,6 -e 5639296581678 -s -l

1Conan.shsh2 = 71.5 KB
DanTheMann15.shsh2 = 40.6 KB

1Conan shsh2  _  DanTheMann15 shsh2 - ExamDiff Pro, Master Edition (999-User Lic 01-21-2022 01 55 21

@DanTheMann15
Copy link
Owner

i tested both builds of the latest release, it does save the updateInstall ticket, the size of the blobs are both 71.5 KB (73,300 bytes).

i suggest trying --nocache to tsschecker.exe so that it re-downloads the caches it creates, it may help fix what you are experiencing.

@SwiftMove
Copy link
Author

Here you go...

Rec.2022-01-24.10.44.41.mp4

@DanTheMann15
Copy link
Owner

Very strange... does the 32-bit build behave the same way as well, - also can you try an older release?

i'm trying to isolate if it's because of how it's compiled or if i somehow introduced a bug in this version. i don't know if it's caused by microsoft changing something in Windows 10.

my builds of tsschecker are compiled using this pair of scripts made to be run on MSYS2.

@DanTheMann15 DanTheMann15 added the bug Something isn't working label Jan 26, 2022
@DanTheMann15 DanTheMann15 self-assigned this Jan 26, 2022
@SwiftMove
Copy link
Author

SwiftMove commented Jan 26, 2022

Ok, I did some more testing today. All tests were done using the latest v0.335.0 release.

Windows 10 [1903, 1909 and 21H1]
32-bit (WORKING)
64-bit (NOT WORKING)

Windows 10 [1709 and 1809]
32-bit (WORKING)
64-bit (WORKING)

Windows 8.1
32-bit (WORKING)
64-bit (WORKING)

So it looks like only the 64-bit version isn't working starting with Windows 10 1903 and higher. I even tested with Windows 11 and the 64-bit version isn't working there either.

@DanTheMann15
Copy link
Owner

DanTheMann15 commented Jan 27, 2022

on Windows terminal they are both bugged on Windows 11. the 32bit version works fine on the traditional command prompt.

i'm going to try compiling on Windows 11 through MSYS2 using the script and see if it makes any difference.

@SwiftMove
Copy link
Author

SwiftMove commented Jan 28, 2022

It's definitely something that changed in Windows 10 1903 and higher since both builds are working fine in Windows 10 1809 and lower. I thought Windows 10 was bad, until Windows 11 came out. Windows 11 makes Windows 10 not seem so bad after all. Of course everything works great on Windows 7 though! Microsoft only cares about being the Master of Regression these days.

@DanTheMann15
Copy link
Owner

ok i'm revisiting this issue, as i am about to prepare a new release.

i have confirmed that this issue occurs when tsschecker is built using MSYS2 and Cygwin.
and have found that it does not occur at all when cross-compiled for windows on Ubuntu.

Windows 7 up to Windows 10 1809 (from your testing) is unaffected by this bug, i don't know what microsoft fucked up in the newer releases to make tsschecker not work correctly when compiled on Windows for Windows.

i have no clue why this happens, or how to fix it. but at least i know i can create new builds of tsschecker for windows that do not have this problem from ubuntu. i'll try to make a script that builds tsschecker for windows on ubuntu.

but eventually i will have a github workflow based on 1Conan's that'll permanently solve this issue within the windows releases (plus make builds for macOS and Linux). but i will make sure this is known, and maybe see if somebody within Cygwin or MSYS2 can figure out whats wrong.

Thanks for bringing this to my attention, i'll bear this issue in mind for the future. and not build releases using MSYS2 or Cygwin :P

@DanTheMann15
Copy link
Owner

BUMP: This problem is now completely fixed in commit b1e5d5f

this is implemented in the latest release: https://github.com/DanTheMann15/tsschecker/releases/tag/0.358.0

so no more problems with tsschecker on MSYS2/Cygwin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants