Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug - mods can use admin tools #71

Closed
wants to merge 1 commit into from

Conversation

falcon-36
Copy link

Fixed bug where mods could use admin tools.

@cypherbits
Copy link
Contributor

Hi, this could be valid, but this works as intended. We seem to check permissions on the inside of the functions. For example, the reset password, we allow to change password for users below our permission level: for example super mods can change password for mods and normal members only.

$stmt=$db->prepare('SELECT null FROM ' . PREFIX . 'members WHERE nickname=? AND status<?;');

See the status < ? where ? is current user status.

@DanWin
Copy link
Owner

DanWin commented Aug 1, 2020

Yes, this is indeed intended. It might be a bit confusing that the features are behind the Admin button on the control bar, but they were meant to be accessible to mods as well. This may however not be desirable by everyone, so perhaps this could be changed into a new setting? Tackling #33 with a much finer permission system, where individual permissions could be given on a per-role or even per-user setting would probably be the best way to go about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants