Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline.run() argument #17

Closed
jacob-rosenthal opened this issue Oct 16, 2020 · 1 comment
Closed

Pipeline.run() argument #17

jacob-rosenthal opened this issue Oct 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jacob-rosenthal
Copy link
Collaborator

The argument of Pipeline.run()should be an object inheriting from BaseSlide, rather than a file path.
This means that whenever we run a pipeline, we can trust that it implements everything from BaseSlide.

If we just pass a path, it may be ambiguous how to read it (is it a H&E slide, or a multiplex slide, or...?). All the work in reading the file, etc. should happen when creating the slide object, not in the pipeline object.

@jacob-rosenthal jacob-rosenthal added the enhancement New feature or request label Oct 21, 2020
@jacob-rosenthal
Copy link
Collaborator Author

This is obsolete with refactor in #92
run() is now a method of SlideData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant