Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heise Shariff support #163

Merged
merged 5 commits into from
Feb 16, 2015
Merged

Add Heise Shariff support #163

merged 5 commits into from
Feb 16, 2015

Conversation

krid78
Copy link

@krid78 krid78 commented Feb 3, 2015

This patch add support for the c't Shariff-Project to offer privacy enabled social media buttons. For more information, see Shariff on GitHub. You may refer to my web-site as an example.

@DonDebonair
Copy link
Owner

Hi Daniel! Thanks for your contribution. I'd love to merge this, but could you please move the javascript tag from the base.html into the article.html, in the script block there? See this commit on how I did this for AddThis as well: b37323a That way the javascript only gets loaded when the template requires it :)

@krid78
Copy link
Author

krid78 commented Feb 10, 2015

Ok, I’ll try if this works on the weekend.

Regards,
Daniel

Am 10.02.2015 um 20:56 schrieb Daan Debie notifications@github.com:

Hi Daniel! Thanks for your contribution. I'd love to merge this, but could you please move the javascript tag from the base.html into the article.html, in the script block there? See this commit on how I did this for AddThis as well: b37323a That way the javascript only gets loaded when the template requires it :)


Reply to this email directly or view it on GitHub.

Daniel Kriesten
daniel@die-kriestens.de
http://www.die-kriestens.de

@krid78
Copy link
Author

krid78 commented Feb 16, 2015

I moved the code accordingly and updated shariff to v1.7.3. As far as I can see on my own site, the code is working and therefore ready to be merged 😊

DonDebonair added a commit that referenced this pull request Feb 16, 2015
@DonDebonair DonDebonair merged commit 0d47386 into DonDebonair:master Feb 16, 2015
@DonDebonair
Copy link
Owner

Great! Merged :)

@krid78 krid78 deleted the heise_shariff branch February 16, 2015 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants