-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firmware retraction fix and extends zhop features. #211
base: master
Are you sure you want to change the base?
Conversation
69783aa
to
ea5b1db
Compare
ea5b1db
to
6116237
Compare
I've been testing this and it works for me except that it still produces warning spam on G10 and G11 commands that should be idempotent. This messes up the start of every print, where the start gcode needs to have left the extruder in retracted state, but Cura also emits its own retraction for the first travel move. Supporting this kind of idempotency instead of double-retracting and messing up priming is, from my perspective, one of the compelling motivations for firmware retract in the first place, so it should not be treated as something abnormal that produces warnings. As discussed on Discord, I would also like to see the issue resolved in a way that makes it possible to use Z-hop and get the right properties for how fw retract is supposed to work. This probably means something like having it so entering retracted state lifts Z by the configured amount, but explicitly moving in Z after that loses the offset and moves to the actual commanded Z height, and so that exiting retracted state only returns to the logical, non-offset Z height (doing nothing if Z was moved since the retract). |
I removed the console outputs
This point doesn't fit my workflow but I think we can do something configurable, for example a boolean |
@fbeauKmi this looks good to me.. would you mind rebasing? ty |
As discuss on Discord, DK firmware and according to issue #204 and PR #206 . I made this for a while some change to fit my use case. I guess it can fix the issue.
Changes from actual firmware_retraction
reset_on_events
parameter. (false : keep retracted state on events, true: reset retracted state and restore config values).SET_RETRACTION
while retractedChecklist