Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockable_probe : Fix _move_avoiding_dock if no safe_area #326

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Dockable_probe : Fix _move_avoiding_dock if no safe_area #326

merged 3 commits into from
Jul 1, 2024

Conversation

fbeauKmi
Copy link
Contributor

@fbeauKmi fbeauKmi commented Jun 26, 2024 •
edited
Loading

According to this issue #322, when the safe_dock_distance is zero _move_avoiding_dock may not correctly calculate an exit point. This PR disables the avoidance function in this situation.

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@fbeauKmi fbeauKmi requested a review from a team as a code owner June 26, 2024 21:25
@ressu
Copy link
Contributor

ressu commented Jun 27, 2024

I can confirm that this change resolves the issue in #322

rogerlz
rogerlz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@rogerlz rogerlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rogerlz rogerlz merged commit b1f014b into DangerKlippers:master Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerlz rogerlz rogerlz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbeauKmi @ressu @rogerlz