Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloakedCode/Mental Dockable Probe #43

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Conversation

bwnance
Copy link
Contributor

@bwnance bwnance commented Aug 11, 2023

annexed_probe: added dock_retries configuration option

annexed_probe: renamed decouple_speed to detach_speed for consistency

Annexed_Probe.md: initial commit of documentation

Config_Reference.md: added annexed_probe config section

annexed_probe: retry attempts must be greater than 1

annexed_probe: redefine default speeds

annexed_probe: changed delayed detach to optional

Annexed_Probe.md: added section for delayed_detach option

Annexed_Probe.md: (fixed invalid characters and whitespace errors

Annexed_Probe.md: Added additional documentation and gcode reference

Config_Reference.md: Removed extra spaces for annexed_probe and added allow_delayed_detach parameter

G-Codes.md: added annexed_probe gcode reference

annexed_probe.py: changed initial position execution to after docking completed

annexed_probe: rename to dockable_probe

dockable_probe: remove ability to set manual_probe_state

dockable_probe: change docking points to discrete coordinates instead of vectors

Annexed_Probe.md: fixed typo in tool velocities

dockable_probe: corrected typos

dockable_probe.py - Corrected typo in _do_detach()

dockable_probe: Python3 compatibility and misc fixes in parseCoord

  • map() returns a iterable which is not sliceable.
  • Fix a bug where the coordinate vector could be resized.
  • Better error reporting.

mental405 and others added 2 commits August 10, 2023 22:18
annexed_probe: added dock_retries configuration option

annexed_probe: renamed decouple_speed to detach_speed for consistency

Annexed_Probe.md: initial commit of documentation

Config_Reference.md: added annexed_probe config section

annexed_probe: retry attempts must be greater than 1

annexed_probe: redefine default speeds

annexed_probe: changed delayed detach to optional

Annexed_Probe.md: added section for delayed_detach option

Annexed_Probe.md: (fixed invalid characters and whitespace errors

Annexed_Probe.md: Added additional documentation and gcode reference

Config_Reference.md: Removed extra spaces for annexed_probe and added allow_delayed_detach parameter

G-Codes.md: added annexed_probe gcode reference

annexed_probe.py: changed initial position execution to after docking completed

annexed_probe: rename to dockable_probe

dockable_probe: remove ability to set manual_probe_state

dockable_probe: change docking points to discrete coordinates instead of vectors

Annexed_Probe.md: fixed typo in tool velocities

dockable_probe: corrected typos

dockable_probe.py - Corrected typo in _do_detach()

dockable_probe: Python3 compatibility and misc fixes in parseCoord

- map() returns a iterable which is not sliceable.
- Fix a bug where the coordinate vector could be resized.
- Better error reporting.

Signed-off-by: Maël Kerbiriou <m431.kerbiriou@gmail.com>
@bwnance bwnance requested a review from kmobs August 11, 2023 02:20
@bwnance bwnance mentioned this pull request Aug 11, 2023
@bwnance bwnance requested a review from rogerlz August 22, 2023 19:11
@rogerlz
Copy link
Contributor

rogerlz commented Aug 27, 2023

upstream pr: Klipper3d/klipper#4328

@rogerlz rogerlz merged commit b3e67e9 into master Aug 27, 2023
1 check passed
@rogerlz rogerlz deleted the dockable_probe_cloakedcode branch August 27, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants