Fix: better filter type for browser runtime port transport (#11)

DaniGuardiola · Dec 20, 2023 · 2e447f8 · 2e447f8
1 parent eea532d
commit 2e447f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/cuddly-dancers-tie.md b/.changeset/cuddly-dancers-tie.md
@@ -0,0 +1,5 @@
+---
+"rpc-anywhere": patch
+---
+
+Fix: better filter type for `createTransportFromBrowserRuntimePort`'s `filter` option.
diff --git a/src/transports/browser-runtime-port.ts b/src/transports/browser-runtime-port.ts
@@ -26,7 +26,7 @@ export type RPCBrowserRuntimePortTransportOptions = Pick<
    * as arguments. For example, messages can be filtered
    * based on `port.name` or `port.sender`.
    */
-  filter?: (message: any, port: Port) => boolean;
+  filter?: (message: any, port: Browser.Runtime.Port) => boolean;
 };
 
 /**
@@ -47,7 +47,7 @@ export function createTransportFromBrowserRuntimePort(
       transportHandler = (message, port) => {
         const [ignore, data] = rpcTransportMessageIn(message, {
           transportId,
-          filter: () => filter?.(message, port),
+          filter: () => filter?.(message, port as Browser.Runtime.Port),
         });
         if (ignore) return;
         handler(data);