Fix: transport utils - ID and filter exclusivity check (#15)

DaniGuardiola · Dec 20, 2023 · 4046d0b · 4046d0b
1 parent f93874e
commit 4046d0b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/four-jobs-tickle.md b/.changeset/four-jobs-tickle.md
@@ -0,0 +1,5 @@
+---
+"rpc-anywhere": patch
+---
+
+Fix: transport utils - ID and filter exclusivity check.
diff --git a/src/transport-utils.ts b/src/transport-utils.ts
@@ -38,7 +38,8 @@ export function rpcTransportMessageIn(
   options: RPCTransportOptions,
 ): [ignore: false, message: any] | [ignore: true] {
   const { transportId, filter } = options;
-  if (transportId != null && filter)
+  const filterResult = filter?.();
+  if (transportId != null && filterResult != null)
     throw new Error(
       "Cannot use both `transportId` and `filter` at the same time",
     );
@@ -48,6 +49,6 @@ export function rpcTransportMessageIn(
     if (message.transportId !== transportId) return [true];
     data = message.data;
   }
-  if (filter?.() === false) return [true];
+  if (filterResult === false) return [true];
   return [false, data];
 }