Add bottomSheetHeight property to countryListThemeData. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2022
|
Nice...thanks...I guess it needs to be added to flutter_currency_picker which uses same code...if Daniel doesnt do it i will later do a PR too |
|
@janar265 , i cannot see your latest message...but i guess 1/3, 2/3 size constant would be great... or something like adjustable height from few elements until a specific max height of 1/3 or 2/3 ( cause if you have 1 single or 2 elements, you expect a flexible height) |
Daniel-Ioannou
approved these changes
Apr 5, 2022
|
Thank you for your contribution. Released in v2.0.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to add functionality of user to decide how tall the country list will be.