Make CleanUrl routes compatible with sites index page when no default site is set #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
This pull request fixes #14
I've changed the module's config code in such a way that the top route is only overridden when there is a default site set in Omeka's main settings and
Skip "s/site-slug/" for default site
is activated in the CleanUrl module settings.I hope my contribution is valuable and will be merged into the CleanUrl code.
Best regards,
Maarten Coonen