Skip to content

Commit

Permalink
Mark PooledJsEngine methods as virtual so they can be mocked for un…
Browse files Browse the repository at this point in the history 
…it tests
  • Loading branch information
@Daniel15
Daniel15 committed Jul 1, 2017
1 parent 0437436 commit 98e68eb
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 21 deletions.
3 changes: 2 additions & 1 deletion src/JSPool/JSPool.csproj
View file
Expand Up @@ -5,7 +5,8 @@

See https://dan.cx/projects/jspool for usage instructions.</Description>
<Copyright>Daniel Lo Nigro</Copyright>
<VersionPrefix>3.0.0</VersionPrefix>
<PackageIconUrl>https://stuff.dan.cx/images/projects/jspool-logo-256.png</PackageIconUrl>
<VersionPrefix>3.0.1</VersionPrefix>
<TargetFrameworks>net40-client;net451;netstandard1.3</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AssemblyName>JSPool</AssemblyName>
Expand Down
38 changes: 19 additions & 19 deletions src/JSPool/PooledJsEngine.cs
View file
Expand Up @@ -39,7 +39,7 @@ public class PooledJsEngine : PooledObject<IJsEngine>, IJsEngine
/// </summary>
/// <param name="expression">JS-expression</param>
/// <returns>Result of the expression</returns>
public object Evaluate(string expression)
public virtual object Evaluate(string expression)
{
return InnerEngine.Evaluate(expression);
}
Expand All @@ -50,7 +50,7 @@ public object Evaluate(string expression)
/// <typeparam name="T">Type of result</typeparam>
/// <param name="expression">JS-expression</param>
/// <returns>Result of the expression</returns>
public T Evaluate<T>(string expression)
public virtual T Evaluate<T>(string expression)
{
return InnerEngine.Evaluate<T>(expression);
}
Expand All @@ -60,7 +60,7 @@ public T Evaluate<T>(string expression)
/// Executes a code
/// </summary>
/// <param name="code">Code</param>
public void Execute(string code)
public virtual void Execute(string code)
{
InnerEngine.Execute(code);
}
Expand All @@ -70,7 +70,7 @@ public void Execute(string code)
/// </summary>
/// <param name="path">Path to the JS-file</param>
/// <param name="encoding">Text encoding</param>
public void ExecuteFile(string path, Encoding encoding = null)
public virtual void ExecuteFile(string path, Encoding encoding = null)
{
InnerEngine.ExecuteFile(path, encoding);
}
Expand All @@ -80,7 +80,7 @@ public void ExecuteFile(string path, Encoding encoding = null)
/// </summary>
/// <param name="resourceName">JS-resource name</param>
/// <param name="type">Type from assembly that containing an embedded resource</param>
public void ExecuteResource(string resourceName, Type type)
public virtual void ExecuteResource(string resourceName, Type type)
{
InnerEngine.ExecuteResource(resourceName, type);
}
Expand All @@ -90,7 +90,7 @@ public void ExecuteResource(string resourceName, Type type)
/// </summary>
/// <param name="resourceName">JS-resource name</param>
/// <param name="assembly">Assembly that containing an embedded resource</param>
public void ExecuteResource(string resourceName, Assembly assembly)
public virtual void ExecuteResource(string resourceName, Assembly assembly)
{
InnerEngine.ExecuteResource(resourceName, assembly);
}
Expand All @@ -101,7 +101,7 @@ public void ExecuteResource(string resourceName, Assembly assembly)
/// <param name="functionName">Function name</param>
/// <param name="args">Function arguments</param>
/// <returns>Result of the function execution</returns>
public object CallFunction(string functionName, params object[] args)
public virtual object CallFunction(string functionName, params object[] args)
{
return InnerEngine.CallFunction(functionName, args);
}
Expand All @@ -113,7 +113,7 @@ public object CallFunction(string functionName, params object[] args)
/// <param name="functionName">Function name</param>
/// <param name="args">Function arguments</param>
/// <returns>Result of the function execution</returns>
public T CallFunction<T>(string functionName, params object[] args)
public virtual T CallFunction<T>(string functionName, params object[] args)
{
return InnerEngine.CallFunction<T>(functionName, args);
}
Expand All @@ -123,7 +123,7 @@ public T CallFunction<T>(string functionName, params object[] args)
/// </summary>
/// <param name="variableName">Variable name</param>
/// <returns>Result of check (true - exists; false - not exists</returns>
public bool HasVariable(string variableName)
public virtual bool HasVariable(string variableName)
{
return InnerEngine.HasVariable(variableName);
}
Expand All @@ -133,7 +133,7 @@ public bool HasVariable(string variableName)
/// </summary>
/// <param name="variableName">Variable name</param>
/// <returns>Value of variable</returns>
public object GetVariableValue(string variableName)
public virtual object GetVariableValue(string variableName)
{
return InnerEngine.GetVariableValue(variableName);
}
Expand All @@ -144,7 +144,7 @@ public object GetVariableValue(string variableName)
/// <typeparam name="T">Type of variable</typeparam>
/// <param name="variableName">Variable name</param>
/// <returns>Value of variable</returns>
public T GetVariableValue<T>(string variableName)
public virtual T GetVariableValue<T>(string variableName)
{
return InnerEngine.GetVariableValue<T>(variableName);
}
Expand All @@ -154,7 +154,7 @@ public T GetVariableValue<T>(string variableName)
/// </summary>
/// <param name="variableName">Variable name</param>
/// <param name="value">Value of variable</param>
public void SetVariableValue(string variableName, object value)
public virtual void SetVariableValue(string variableName, object value)
{
InnerEngine.SetVariableValue(variableName, value);
}
Expand All @@ -163,7 +163,7 @@ public void SetVariableValue(string variableName, object value)
/// Removes a variable
/// </summary>
/// <param name="variableName">Variable name</param>
public void RemoveVariable(string variableName)
public virtual void RemoveVariable(string variableName)
{
InnerEngine.RemoveVariable(variableName);
}
Expand All @@ -173,7 +173,7 @@ public void RemoveVariable(string variableName)
/// </summary>
/// <param name="itemName">Name of the item</param>
/// <param name="value">Value of the item</param>
public void EmbedHostObject(string itemName, object value)
public virtual void EmbedHostObject(string itemName, object value)
{
InnerEngine.EmbedHostObject(itemName, value);
}
Expand All @@ -183,15 +183,15 @@ public void EmbedHostObject(string itemName, object value)
/// </summary>
/// <param name="itemName">Name of the type</param>
/// <param name="type">The type</param>
public void EmbedHostType(string itemName, Type type)
public virtual void EmbedHostType(string itemName, Type type)
{
InnerEngine.EmbedHostType(itemName, type);
}

/// <summary>
/// Collects the garbage.
/// </summary>
public void CollectGarbage()
public virtual void CollectGarbage()
{
InnerEngine.CollectGarbage();
}
Expand All @@ -202,7 +202,7 @@ public void CollectGarbage()
/// <param name="expression">JS-expression</param>
/// <param name="documentName">Document name</param>
/// <returns>Result of the expression</returns>
public object Evaluate(string expression, string documentName)
public virtual object Evaluate(string expression, string documentName)
{
return InnerEngine.Evaluate(expression, documentName);
}
Expand All @@ -214,7 +214,7 @@ public object Evaluate(string expression, string documentName)
/// <param name="expression">JS-expression</param>
/// <param name="documentName">Document name</param>
/// <returns>Result of the expression</returns>
public T Evaluate<T>(string expression, string documentName)
public virtual T Evaluate<T>(string expression, string documentName)
{
return InnerEngine.Evaluate<T>(expression, documentName);
}
Expand All @@ -224,7 +224,7 @@ public T Evaluate<T>(string expression, string documentName)
/// </summary>
/// <param name="code">JS-code</param>
/// <param name="documentName">Document name</param>
public void Execute(string code, string documentName)
public virtual void Execute(string code, string documentName)
{
InnerEngine.Execute(code, documentName);
}
Expand Down
2 changes: 1 addition & 1 deletion src/JSPool/PooledObject.cs
View file
Expand Up @@ -29,7 +29,7 @@ public abstract class PooledObject<T> : IDisposable
/// <summary>
/// Returns this engine to the pool.
/// </summary>
public void Dispose()
public virtual void Dispose()
{
ReturnEngineToPool();
}
Expand Down

0 comments on commit 98e68eb

Please sign in to comment.