Skip to content

Commit

Permalink
Fixed NuGet#315 by explicitly requiring usernames for logon
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffhandley committed Dec 6, 2011
1 parent a821f05 commit 462701a
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 24 deletions.
6 changes: 3 additions & 3 deletions Facts/Controllers/AuthenticationControllerFacts.cs
Expand Up @@ -35,7 +35,7 @@ public void WillLogTheUserOnWhenTheUsernameAndPasswordAreValidAndUserIsConfirmed
userSvc: userSvc);

controller.LogOn(
new SignInRequest() { UserNameOrEmail = "theUsername", Password = "thePassword" },
new SignInRequest() { UserName = "theUsername", Password = "thePassword" },
"theReturnUrl");

formsAuthSvc.Verify(x => x.SetAuthCookie(
Expand All @@ -57,7 +57,7 @@ public void WillNotLogTheUserOnWhenTheUsernameAndPasswordAreValidAndUserIsNotCon
userSvc: userSvc);

controller.LogOn(
new SignInRequest() { UserNameOrEmail = "theUsername", Password = "thePassword" },
new SignInRequest() { UserName = "theUsername", Password = "thePassword" },
"theReturnUrl");
}

Expand All @@ -77,7 +77,7 @@ public void WillLogTheUserOnWithRolesWhenTheUsernameAndPasswordAreValidAndUserIs
userSvc: userSvc);

controller.LogOn(
new SignInRequest() { UserNameOrEmail = "theUsername", Password = "thePassword" },
new SignInRequest() { UserName = "theUsername", Password = "thePassword" },
"theReturnUrl");

formsAuthSvc.Verify(x => x.SetAuthCookie(
Expand Down
3 changes: 1 addition & 2 deletions Website/Controllers/AuthenticationController.cs
Expand Up @@ -33,9 +33,8 @@ public virtual ActionResult LogOn(SignInRequest request, string returnUrl)
if (!ModelState.IsValid)
return View();

// TODO: allow users to sign in with email address in addition to user name
var user = userSvc.FindByUsernameAndPassword(
request.UserNameOrEmail,
request.UserName,
request.Password);

if (user == null)
Expand Down
4 changes: 2 additions & 2 deletions Website/RequestModels/SignInRequest.cs
Expand Up @@ -6,8 +6,8 @@ public class SignInRequest
{
[Required]
[Display(Name = "Username")]
[Hint("Enter either your username or email address.")]
public string UserNameOrEmail { get; set; }
[Hint("Enter your username.")]
public string UserName { get; set; }

[Required]
[DataType(DataType.Password)]
Expand Down
34 changes: 17 additions & 17 deletions Website/Views/Authentication/LogOn.generated.cs
Expand Up @@ -2,7 +2,7 @@
//------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.239
// Runtime Version:4.0.30319.488
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
Expand Down Expand Up @@ -45,7 +45,7 @@ public override void Execute()
{


WriteLiteral("\n<h1>Log On</h1>\n\n<p>\n Don\'t have an account yet? <a href=\"");
WriteLiteral("\r\n<h1>Log On</h1>\r\n\r\n<p>\r\n Don\'t have an account yet? <a href=\"");



Expand All @@ -55,7 +55,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\">Register now.</a>\n</p>\n\n");
WriteLiteral("\">Register now.</a>\r\n</p>\r\n\r\n");



Expand All @@ -65,7 +65,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral(" <fieldset class=\"form\">\n <legend>Log On Form</legend>\n\n ");
WriteLiteral(" <fieldset class=\"form\">\r\n <legend>Log On Form</legend>\r\n\r\n ");



Expand All @@ -75,7 +75,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n ");
WriteLiteral("\r\n ");



Expand All @@ -85,7 +85,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n\n");
WriteLiteral("\r\n\r\n");



Expand All @@ -104,7 +104,7 @@ public override void Execute()



WriteLiteral(" <p class=\"validation-summary-errors\">\n ");
WriteLiteral(" <p class=\"validation-summary-errors\">\r\n ");



Expand All @@ -114,7 +114,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n </p>\n");
WriteLiteral("\r\n </p>\r\n");



Expand All @@ -124,7 +124,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n ");
WriteLiteral("\r\n ");



Expand All @@ -134,7 +134,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n\n <img src=\"");
WriteLiteral("\r\n\r\n <img src=\"");



Expand All @@ -144,8 +144,8 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\" alt=\"Blue border on left means required.\" />\n\n <input type=\"submit\" valu" +
"e=\"Log On\" title=\"Log On\" />\n ");
WriteLiteral("\" alt=\"Blue border on left means required.\" />\r\n\r\n <input type=\"submit\" va" +
"lue=\"Log On\" title=\"Log On\" />\r\n ");



Expand All @@ -155,7 +155,7 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n </fieldset>\n");
WriteLiteral("\r\n </fieldset>\r\n");



Expand All @@ -165,12 +165,12 @@ public override void Execute()

#line default
#line hidden
WriteLiteral("\n");
WriteLiteral("\r\n");


DefineSection("BottomScripts", () => {
WriteLiteral("\n <script src=\"");
WriteLiteral("\r\n <script src=\"");
Expand All @@ -180,7 +180,7 @@ public override void Execute()
#line default
#line hidden
WriteLiteral("\"></script>\n <script src=\"");
WriteLiteral("\"></script>\r\n <script src=\"");
Expand All @@ -190,7 +190,7 @@ public override void Execute()
#line default
#line hidden
WriteLiteral("\"></script>\n");
WriteLiteral("\"></script>\r\n");
});
Expand Down

0 comments on commit 462701a

Please sign in to comment.