Remove the additional slash. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base should be 'https://nuget.xxxxxxxxxxxxxx.com/' and not 'http://nuget.xxxxxxxxxxxxxx.com//.' It seems to be the double slash at the end that is breaking the request. Nuget tries to resolve it to Resolved actions to install package 'xxxxxxxxxx.5.1.0.47-develop' `GET http://nuget.xxxxxxxxxxxxxx.com//download/xxxxxxxxxx/5.1.0.47-develop` When I call that directly I only a response Only DELETEs allowed here. If I remove the double slash it works. See this issue. sunsided/docker-nuget#7 for more details.
|
I think it should actually check if This is likely a better fix: - dirname($_SERVER['REQUEST_URI']) . '/';
+ rtrim(dirname($_SERVER['REQUEST_URI']), '/') . '/';Would you be willing to test that out and update this PR? |
|
Makes sense. Will test it out. |
|
It worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base should be 'https://nuget.xxxxxxxxxxxxxx.com/' and not 'http://nuget.xxxxxxxxxxxxxx.com//.'
It seems to be the double slash at the end that is breaking the request.
Nuget tries to resolve it to
Resolved actions to install package 'xxxxxxxxxx.5.1.0.47-develop'
GET http://nuget.xxxxxxxxxxxxxx.com//download/xxxxxxxxxx/5.1.0.47-developWhen I call that directly I only a response Only DELETEs allowed here. If I remove the double slash it works.