Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'COLLATE NOCASE' to findByID #41

Merged
merged 1 commit into from Oct 28, 2019
Merged

Conversation

oletolshave
Copy link

Using simple-nuget-ser as nuget server (running on the default SQLite in docker) and doing a "dotnet tool install ..." the install woud fail because the package could not be found.

I traced it down to "dotnet tool install" trying to find an all lowercase version of the package. I think the nuget api is supposed to be case IN-sensitive, so I guess this is a bug in simple-nuget-server.

Adding "COLLATE NOCASE" to the lookup makes "dotnet tool install" happy.

@loic-sharma
Copy link

I traced it down to "dotnet tool install" trying to find an all lowercase version of the package. I think the nuget api is supposed to be case IN-sensitive, so I guess this is a bug in simple-nuget-server.

NuGet.org's package ID database column is indeed case insensitive 👍

@Daniel15
Copy link
Owner

It's probably better to do this in the CREATE TABLE statement, but that wouldn't affect existing databases (of course). This seems reasonable to me. Thanks!

@Daniel15 Daniel15 merged commit 6a3f9b9 into Daniel15:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants