Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong parsing #36

Open
piv199 opened this issue Jul 15, 2017 · 3 comments
Open

wrong parsing #36

piv199 opened this issue Jul 15, 2017 · 3 comments

Comments

@piv199
Copy link

piv199 commented Jul 15, 2017

"They used to work here, _____ they?",hadn't,weren't,didn't,used not,0,0,1,0,4

Created through Microsoft Excel, but "They used to work here, _____ they?" parsed as two different tokens, instead of one.

So quotes are ignored, it seems...

@Daniel1of1
Copy link
Owner

Thanks for the issue. For reference - what is the your expected outcome for the above string?

I assume:

[
"They used to work here, _____ they?",
"hadn't",
"weren't",
"didn't",
"used not",
"0",
"0",
"1",
"0",
"4"
]

Is that correct?

@piv199
Copy link
Author

piv199 commented Jul 16, 2017

@Daniel1of1 yes, so if the string starts with " then the whole token is up to ",, as far as I understand from excel.

Also there could be " inside token, they should be left as is.

Daniel1of1 added a commit that referenced this issue May 31, 2019
This may have been a misinturpretation on my part of whether to include
quotes or not. See this issue: #36
@Daniel1of1
Copy link
Owner

Incase this is still an issue for you, the latest develop should have this behaviour now.
And to make clear my previous point expected string should actually be: (different first line)

[
"\"They used to work here, _____ they?\"",
"hadn't",
"weren't",
"didn't",
"used not",
"0",
"0",
"1",
"0",
"4"
]

Right?

( no worries if this long past being an issue 😊 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants