Updated to Swift 3.0 for Xcode 8 Beta 2 #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2016 21:23
|
Hi @notronik - I was going through outstanding PRs in chronological order (ish) so got in swift 3.0 with #18 and #19. Thank you for taking the time to maintain the fork and sorry for taking so long to get back. Now building on Beta 3. I'll close this now since it's been brought in from previous PRs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So like PR #18 and #19, I too ran the migration tool to update the project and tests to Swift 3.0. I then fixed the bits that broke between Beta 1 and Beta 2 for use in my own project. I also upgraded the CSwiftV Xcode project to the new recommended settings, which means that whole module optimisation is now enabled for all targets. All tests are passing.
Since those two PRs exist already I'm not expecting this to be merged, but for anyone that is looking for a version that works with Swift 3.0 on Xcode 8 Beta 2, perhaps you might consider to use my fork for the time being.