Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a User I want to join a Tournament #8

Open
2 of 3 tasks
DanielLarsenNZ opened this issue Dec 1, 2020 · 4 comments
Open
2 of 3 tasks

As a User I want to join a Tournament #8

DanielLarsenNZ opened this issue Dec 1, 2020 · 4 comments
Assignees
Projects
Milestone

Comments

@DanielLarsenNZ
Copy link
Owner

DanielLarsenNZ commented Dec 1, 2020

  • User can add another GameOn User (that already exists in GameOn) to a Tournament that they are in
  • Backend
  • Frontend UI @olafwrieden
@DanielLarsenNZ DanielLarsenNZ created this issue from a note in GameOn-Dev (To do) Dec 1, 2020
@DanielLarsenNZ DanielLarsenNZ added this to the Release1 milestone Dec 1, 2020
@DanielLarsenNZ DanielLarsenNZ moved this from To do to In progress in GameOn-Dev Dec 16, 2020
@olafwrieden
Copy link
Collaborator

@DanielLarsenNZ we need a POST /tournaments/{tenant_id}/{id}/players or similar endpoint so people can join. I don't remember why we proposed a /players/{tournament_id} route in the docs as players are depended on the tournament... it might be better practice to stick to the above convention.

@olafwrieden olafwrieden added the Blocked (MSAL Required) Unable to mark as 'Done' until authentication is integrated on back and front-end. label Dec 21, 2020
@DanielLarsenNZ
Copy link
Owner Author

Or possibly /tournaments/(tenantId)/(tournamentId)/join ?

@DanielLarsenNZ DanielLarsenNZ removed the Blocked (MSAL Required) Unable to mark as 'Done' until authentication is integrated on back and front-end. label Dec 30, 2020
DanielLarsenNZ added a commit that referenced this issue Jan 4, 2021
DanielLarsenNZ added a commit that referenced this issue Jan 4, 2021
@DanielLarsenNZ
Copy link
Owner Author

A User can now add another GameOn User (that already exists in GameOn) to a Tournament that they are in. This has been deployed to Prod.

DanielLarsenNZ added a commit that referenced this issue Mar 1, 2021
@DanielLarsenNZ
Copy link
Owner Author

@olafwrieden I ended up changing the endpoint to accept a model. This is a breaking change sorry.

POST /tournaments/{tournament_id}/players
Content-Type: application/json
Authorization: Bearer {{accessToken}}

{
    "playerId": String?,
    "playerIds": String[]?,
    "addMe": Bool?
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GameOn-Dev
In progress
Development

No branches or pull requests

2 participants