Noah/multiple endpoints #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge conflict resolution on GameOn service resolved for rebase Update/ Put Tournament Resolving abc WIP on Tournaments query endpoints WIP on Results endpoints Refactor Delete method into Generic GameOn Service
ncostar
force-pushed
the
noah/multiple-endpoints
branch
from
b1320ea
to
9e30bc8
Compare
Creation date nullable to check for value
Added tournament Id property to Match result to track tournament affiliation
2 tasks
2 tasks
This was
linked to
issues
Sep 13, 2021
2 tasks
3 tasks
2 tasks
2 tasks
DanielLarsenNZ
requested changes
Feb 18, 2022
Comment on lines
+101
to
+105
| catch (NotFoundException ex) | ||
| { | ||
| // log Not Found Exception and return 404 | ||
| _log.LogError(ex, ex.Message); | ||
| return NotFound(ex.Message); |
There was a problem hiding this comment.
FYI @ncostar I added not-found handling here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current WIP with remaining endpoints specified under
api.md. ExcludesUserendopoints.