Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ashish: Add log functionality to tracer #103

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Ashish: Add log functionality to tracer #103

merged 1 commit into from
Aug 30, 2020

Conversation

ashishmahi
Copy link
Contributor

@ashishmahi ashishmahi commented Aug 29, 2020 •
edited
Loading

this PR adds logging functionality to the tracer. it sends logs as separate from tags. It add logs in annotation but as binaryAnnotations.

Issue Solved: #102

@ashishmahi ashishmahi mentioned this pull request Aug 29, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 411c4a0 on ashishmahi:master into f601099 on DanielMSchmidt:master.

DanielMSchmidt
DanielMSchmidt approved these changes Aug 30, 2020
View reviewed changes
Copy link
Owner

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I love it 👍 Great fix, I'll still publish it as a breaking change as it will change the effect a log has and therefore might change expected behaviours

@DanielMSchmidt DanielMSchmidt merged commit ee918c0 into DanielMSchmidt:master Aug 30, 2020
@ashishmahi
Copy link
Contributor Author

thanks @DanielMSchmidt . happy to see my code merged here.
thanks again.

@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashishmahi @coveralls @DanielMSchmidt