Particles per second parameter apparently does not change anything

[ANPez]

I see the same result when passing "1" as parameters as when 1000.

[DanielMartinus]

Thanks for reporting @ANPez

I did a quick look in the code and as far as I can see is that amountPerMs is calculated when the StreamEmitter is created here:

Konfetti/konfetti/src/main/java/nl/dionsegijn/konfetti/emitters/StreamEmitter.kt

Line 29 in c242aec

amountPerMs = TimeUnit.NANOSECONDS.toMillis(1000L / particlesPerSecond)

But not used when the particles are being created here

Konfetti/konfetti/src/main/java/nl/dionsegijn/konfetti/emitters/StreamEmitter.kt

Lines 33 to 51 in c242aec

	/**
	* If timer isn't started yet, set initial start time
	* Create the first confetti immediately and update the last emit time
	*/
	override fun createConfetti(deltaTime: Float) {
	// if maxParticles is set and particlesCreated not within
	// range of maxParticles stop emitting
	if(maxParticles in 1..(particlesCreated - 1)) {
	return
	}
	// Check if particle should be created
	if (deltaTime >= amountPerMs && elapsedTime < emittingTime) {
	this.addConfetti()
	}
	elapsedTime += deltaTime * 1000
	}

I'll make some time to implement this properly and see if I can cover this with tests. But I have not much time until the weekend. A Pull request is welcome ofcourse if there is no time to wait.

In the meantime you might be able to achieve the same by creating more than one particle stream if you need a lot of particles creations happening at the same time. For a slower rate there needs to be a fix.

[DanielMartinus]

Hi @ANPez,

To fix the particles per second bug I've refactored the StreamEmitter. I've opened a pull request which also contains a couple of other fixes such as rewriting the RenderSystem to make it all more testable. You'll also find tests in the pull request referenced in this issue.

I'm not exactly sure when I'll push an update for the library, for now the pull request isn't merged yet. I'll update you on the progress.

[DanielMartinus]

New release: https://github.com/DanielMartinus/Konfetti/releases/tag/1.1.0

[ANPez]

Thanks! Really appreciate your work 👍