Migrate core module to jvm only module #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMartinus
force-pushed
the
migrate-core-to-jvm-only-module
branch
from
8483255
to
53ee16b
Compare
… and ImageStore for efficiency and compatibility
Looks like this was no longer included as core module transitioned to a jvm only module
DanielMartinus
force-pushed
the
migrate-core-to-jvm-only-module
branch
from
53ee16b
to
5a4ba38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support desktop compose, the core module needs to be jvm only. This PR supports the migration of removing all android references in the core module.
android.graphics.RectFand Rectandroid.graphics.drawable.Drawable. The drawable isn't used in the core module, so instead a ReferenceImage is used and the Drawable is stored in the outer modules. This way it's efficiently stored and not passed around as Drawable (not possible) or ByteBuffer (possible but inefficient).android.content.res.Resources, remove reference and instead let every module set their pixelDensity as soon as the PartySystem is being initialized.In order to Support the new CoreImage, ReferenceImage and ImageDrawable objects every module needed to update their DrawShapes functionality.
Other changes