Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a file for the base classes for Formatters #17

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Create a file for the base classes for Formatters #17

merged 2 commits into from
Jan 4, 2022

Conversation

Pierre-Sassoulas
Copy link
Collaborator

Refactor prior to #15

@coveralls
Copy link

coveralls commented Jan 4, 2022 •
edited

Pull Request Test Coverage Report for Build 1654334900

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1650680810: 0.0%
Covered Lines: 165
Relevant Lines: 165
💛 - Coveralls

DanielNoord
DanielNoord reviewed Jan 4, 2022
View reviewed changes
Copy link
Owner

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all the work you did I need to take another good look at what is private and isn't, but I think it would make sense to expose these two classes in the public API.

DanielNoord
DanielNoord approved these changes Jan 4, 2022
View reviewed changes
pydocstringformatter/formatting/base.py Outdated Show resolved Hide resolved
pydocstringformatter/formatting/base.py Outdated Show resolved Hide resolved
pydocstringformatter/formatting/base.py Outdated Show resolved Hide resolved
pydocstringformatter/formatting/base.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas @DanielNoord
Add dot at the end of the docstring following pep257
f4cd08c 
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas added this to the 0.3.0 milestone Jan 4, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 065c8e1 into main Jan 4, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the refactor-formatter-module branch January 4, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord