Fix false-positive useless-suppression for line-too-long

Also changes ``add_ignored_message()`` to make ``nodes`` parameter
optional.
Closes pylint-dev#4212

ChangeLog

@@ -47,6 +47,10 @@ Release date: TBA
 
   Closes #5066
 
+* Fix false-positive ``useless-suppression`` for ``line-too-long``
+
+  Closes #4212
+
 
 What's New in Pylint 2.11.1?
 ============================

pylint/checkers/format.py

@@ -673,15 +673,18 @@ def check_line_ending(self, line: str, i: int) -> None:
                 "trailing-whitespace", line=i, col_offset=len(stripped_line)
             )
 
-    def check_line_length(self, line: str, i: int) -> None:
+    def check_line_length(self, line: str, i: int, checker_off: bool) -> None:
         """
         Check that the line length is less than the authorized value
         """
         max_chars = self.config.max_line_length
         ignore_long_line = self.config.ignore_long_lines
         line = line.rstrip()
         if len(line) > max_chars and not ignore_long_line.search(line):
-            self.add_message("line-too-long", line=i, args=(len(line), max_chars))
+            if checker_off:
+                self.linter.add_ignored_message("line-too-long", i)
+            else:
+                self.add_message("line-too-long", line=i, args=(len(line), max_chars))
 
     @staticmethod
     def remove_pylint_option_from_lines(options_pattern_obj) -> str:
@@ -775,16 +778,16 @@ def check_lines(self, lines: str, lineno: int) -> None:
 
         # Line length check may be deactivated through `pylint: disable` comment
         mobj = OPTION_PO.search(lines)
+        checker_off = False
         if mobj:
             if not self.is_line_length_check_activated(mobj):
-                # the line length check is deactivated, we can stop here
-                return
+                checker_off = True
             # The 'pylint: disable whatever' should not be taken into account for line length count
             lines = self.remove_pylint_option_from_lines(mobj)
 
         # here we re-run specific_splitlines since we have filtered out pylint options above
         for offset, line in enumerate(self.specific_splitlines(lines)):
-            self.check_line_length(line, lineno + offset)
+            self.check_line_length(line, lineno + offset, checker_off)
 
     def check_indent_level(self, string, expected, line_num):
         """return the indent level of the string"""

pylint/message/message_handler_mix_in.py

@@ -261,7 +261,7 @@ def add_ignored_message(  # type: ignore # MessagesHandlerMixIn is always mixed
         self: "PyLinter",
         msgid: str,
         line: int,
-        node: nodes.NodeNG,
+        node: Optional[nodes.NodeNG] = None,
         confidence: Optional[Confidence] = UNDEFINED,
     ) -> None:
         """Prepares a message to be added to the ignored message storage

tests/functional/u/useless/useless_suppression.py

@@ -1,6 +1,11 @@
-"""Test for useless suppression false positive for wrong-import-order
-Reported in https://github.com/PyCQA/pylint/issues/2366"""
-# pylint: enable=useless-suppression
+"""Test for useless suppressions"""
+# pylint: enable=useless-suppression, line-too-long
 # pylint: disable=unused-import, wrong-import-order
+
+# False positive for wrong-import-order
+# Reported in https://github.com/PyCQA/pylint/issues/2366
 from pylint import run_pylint
 import astroid
+
+# False-positive for 'line-too-long'
+VAR = "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX" # pylint: disable=line-too-long