Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New license and __unicode__() #5

Closed
wants to merge 6 commits into from

Conversation

nueverest
Copy link
Contributor

I updated the license. I think I'm doing this right. I more familiar with mercurial than git so I'm still learning about how to contribute properly.

I changed the license info.

Added a unicode() method

@DanielOaks
Copy link
Owner

Thanks for looking into it! Git's a little difficult to work with sometimes, but if you're working on a fork (and want to integrate upstream back in at some point), it's best to do all of your own work on branches.

For instance, try to leave master with upstream-only code. If you wanna do some test-case work on your fork, create a test-case branch and do it on there, merging updated upstream stuff in from master occasionally. This makes pull requests quite a bit nicer, and means you can keep your own stuff updated with upstream a lot easier.

Regardless, thank you a whole bunch for these changes, and for making the code more robust!

I've merged it in manually, so this particular change doesn't need to go through a Github pull request. Feel absolutely free to send anything else my way, I'm glad the way it's been going!

@DanielOaks DanielOaks closed this Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants